Skip to content

Nullable annotation added in constructor argument. #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

soumyaPrakashB
Copy link
Contributor

@soumyaPrakashB soumyaPrakashB commented Dec 20, 2022

In one of the constructors of the AggregationOptions class, Nullable annotation is missing for an argument. This cursor parameter canbe null, however as it is not marked as Nullable, in some projects the sonar quality check is failing stating the reason "Nullness of parameters should be guaranteed."

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

In one of the constructors of the AggregationOptions class, Nullable annotation is missing for an argument. This cursor parameter canbe null, however as it is not marked as Nullable, in some projects the sonar quality check is failing stating the reason "Nullness of parameters should be guaranteed."
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 20, 2022
christophstrobl pushed a commit that referenced this pull request Jan 16, 2023
For one of constructor arguments of the AggregationOptions the Nullable annotation for the cursor argument is missing.

Closes: #4256
@christophstrobl
Copy link
Member

Thank you @soumyaPrakashB!

@christophstrobl christophstrobl added this to the 4.1 M1 (2023.0.0) milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants